search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
258 stars 45 forks source link

Fixed the glitch issue #111

Closed geraldmwangi closed 7 years ago

geraldmwangi commented 7 years ago

The internal buffers have to be cleared before processing after beat

geraldmwangi commented 7 years ago

There is still a glitch at the end of a looped clip. The problem is not in TimeManager but in LooperClip.

geraldmwangi commented 7 years ago

by the way: the issue with a glitch at the end of a clip is a non-issue. I used a loop recorded before applying my fixes. Recording/Looping now is completely glitch free

harryhaaren commented 7 years ago

This pull-request was merged using command line - I've rebased the "forgot some buffers" commit into the same commit, and committed one change after these commits to turn off the "reset looper on setBpm()" changes. Details in the commit message, but I don't like the retrigger noises - I understand the loops go out of sync - but I see that as a overall more musical experience than retriggers...

Thanks for the work - appreciated the bugfixes! Thanks agian, -Harry

https://github.com/openAVproductions/openAV-Luppp/commit/bc71739b3a41844c23f24aaab24de28da384adf5