Reverb Send -> master return doesnt work

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.

http://openavproductions.com/luppp

GNU General Public License v3.0

258 stars 45 forks source link

Reverb Send -> master return doesnt work #117

Closed georgkrause closed 7 years ago

georgkrause commented 7 years ago

i played with Luppp a little today and have a issue: i connect the send to a reverb and route the signal back to the master returns, but dont have a signal from the reverb.

harryhaaren commented 7 years ago

Noted: this is a genuine bug, thanks for reporting. Looking into it a little more, there's a FIXME in the code. https://github.com/openAVproductions/openAV-Luppp/blob/master/src/jack.cxx#L475, and this is related to https://github.com/openAVproductions/openAV-Luppp/issues/96

geraldmwangi commented 7 years ago

Oh god, that was my crap-tastic error. @harryhaaren sorry for the inconvenience. Gerald

harryhaaren commented 7 years ago

@geraldmwangi not at all - the buffer overflow bug was causing clicks from the master-return track - hence it was disabled. Thanks for fixing - that's why I re-enabled it :)