openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
258 stars 45 forks source link

Keyboard Layouts #118

Closed georgkrause closed 6 years ago

georgkrause commented 7 years ago

I use Luppp with a german keyboard and when i want to trigger the clips i run in some trouble. i guess the problem is the hardcoded english keyboard.

the problem occurs on y/z and Shift+Number. On my keyboard it is: 1 - ! 2 - " 3 - § 4 - $ 5 - % 6 - & 7 - / 8 - ( 9 - )

i know how to change it in the code, but i would like to request the feature to change it in the settings.

harryhaaren commented 7 years ago

Sorry, low priority.. things like internationalization are hard to do right, and I hope musicians don't use the keyboard... build an Arduino based MIDI controller :D

@ALL reading this: +1 this if you would like to see this happen.

georgkrause commented 7 years ago

well, i own a midi controller so its not that problem for me, but in my eyes its a bug when the keyboard triggers the wrong clip...

georgkrause commented 6 years ago

Maybe this is related to #188

harryhaaren commented 6 years ago

If somebody files a PR then I'll merge, no issue there. In needs to fix the problem correctly (aka, existing keyboard language still work, and more can be added easily). Perhaps it is better to use the scan-key code (which I belive doesn't change, if the keyboard layout changes).

harryhaaren commented 6 years ago

PR's still welcome, closing this to clean up for now. Will re-open when a dev gets time to work on it.