search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
259 stars 45 forks source link

prepare the gui for more tracks #129

Closed georgkrause closed 6 years ago

georgkrause commented 7 years ago

maybe even more magic numbers than before, but it works ;)

georgkrause commented 7 years ago

@harryhaaren i am new to c++, but you are using a initialisation list in the GTrack-Constructor, right? Maybe it would be good to change this and initialise the parameter in the constructor. In this case all the number stuff can be done a little more clearly and the Labels of the Buttons in the Tracks can be set to the Letter only if the track width falls under 80 (lowest for XKey) or maybe 50 (lowest possible for Snd)

georgkrause commented 7 years ago

luppp24

looks like this with 24 tracks, absolutly exaggerated, just wanted to try ;)

harryhaaren commented 7 years ago

This seems included in https://github.com/openAVproductions/openAV-Luppp/pull/127 too? If so, I'll mark this as closed, and pull these changes as part of the other patchset.

georgkrause commented 7 years ago

yes, at the beginning i run in some troubles with git, so the one patch is double. i could fix this if you want, because this feature isnt ready and need some more work.

harryhaaren commented 7 years ago

Ah ok, in that case, I'll not merge it from the other pull request either. Please ping me here when you feel this is ready for merge.

harryhaaren commented 7 years ago

Moving to release 1.2, as this is a new feature, and shouldn't block 1.1 release :)

georgkrause commented 7 years ago

great for me, in the best case we have an conversation about on irc, but dont feel pressure, its maybe an issue for next year from my point of view.

georgkrause commented 7 years ago

@harryhaaren i move this one from 1.2 to future release. my plan with the hole feature set is:

I already started some GUI rework in this PR, but this is far away from ready, we need some more discussions about and maybe we should connect this with some other issues. But there is another thing to think about: running Luppp with another number of tracks and scenes needs intensive testing. we can achieve that by adding the CLI option to allow power-users to change the number, but prevent normal users to run into trouble they cannot solve. So i think it is a pretty good idea to have one release with the engine changes, and do the gui stuff in a later one.

vale981 commented 6 years ago

Is there something going to happen here?

harryhaaren commented 6 years ago

Hi @vale981, I'll leave George answer as the dev behind this PR, but I don't see myself making changes here. Do you have a use case to change the number of tracks?

vale981 commented 6 years ago

Well. 8x8 is good for controllers. And more would be a bit heavy.

Maybe we could implement dynamic scenes. (Like Ctrl click to assign)

On 25 March 2018 21:18:10 CEST, Harry van Haaren notifications@github.com wrote:

Hi @vale981, I'll leave George answer as the dev behind this PR, but I don't see myself making changes here. Do you have a use case to change the number of tracks?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/openAVproductions/openAV-Luppp/pull/129#issuecomment-375995740

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

harryhaaren commented 6 years ago

In theory possible yes. The code is currently quite "static" in how NTRACKS and NSCENES, but it is possible. We would need to be sure removing tracks won't introduce bugs (use-after-free type things), but that should be managable.

For me, its about using time wisely - is this the highest important thing to fix?

vale981 commented 6 years ago

Not immediately. More record modes etc. and clipping samples would be neat.

On 25 March 2018 21:55:31 CEST, Harry van Haaren notifications@github.com wrote:

In theory possible yes. The code is currently quite "static" in how NTRACKS and NSCENES, but it is possible. We would need to be sure removing tracks won't introduce bugs (use-after-free type things), but that should be managable.

For me, its about using time wisely - is this the highest important thing to fix?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/openAVproductions/openAV-Luppp/pull/129#issuecomment-375998419

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

georgkrause commented 6 years ago

@vale981 Please open new Issues for each idea or feature request, its better than discussing this here.

I planned to get back to this work pretty soon, because i already get into the topic, got some tipps from Harry and i think its always good to make the used infrastructure as flexible as possible (running luppp with a specified number of tracks and scenes may be also good for weaker hardware, eg 4x4 or something). So, i want to spend some time on this.

If there is anything I could do in the same time, eg making scenes more flexible and allow them to be specified individually, i could take a look at this too. But in my opinion it would be good to do this in another PR. Any thoughts, @harryhaaren?

Anyway, since some time was passing by, i need to restart my work on this PR or need a full rebase. Lets see what i can do after holidays.

georgkrause commented 6 years ago

I will close this and start this from the current master again to make it easier to merge.