openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
258 stars 45 forks source link

implemented the saveDirectory option #136

Closed geraldmwangi closed 7 years ago

georgkrause commented 7 years ago

i tested and it works. @harryhaaren from my point of view you can merge

harryhaaren commented 7 years ago

Hi @geraldmwangi - this doesn't apply cleanly to current head - does it depend on another patchset? I'll get to look at some PRs between Sat to Tuesday, so lets make a plan to get as much merged as we can :) Cheers, -H

geraldmwangi commented 7 years ago

Hi Harry Its based off rev: SHA-ID e5e57d7a7441e7a80afa85fabd5eb466ec692adb. That's the commit I started the send-returns stuff on. You wanted independent PR's.

harryhaaren commented 7 years ago

@georgkrause : this is expected to work 100% (given it was an easy rebase) but if you have some time, a quick test would be appreciated. Thanks @geraldmwangi for the pull request!