Refactoring of TimeManager

geraldmwangi commented 7 years ago

I would like to suggest a redesign of TimeManager class and the TimeObserver class. The features I would like to implement are the following:

Flexible bar/beat measure (5/4, 7/8 ..)
Finer Quantization for all Events. Currently luppp quantizes bar-wise. SooperLooper could be a reference
Nudge functionality: instantly set the first beat, to correctly sync luppp with other musicians. together with Tap-tempo a drummer, percussionist could controll the TimeManager with a pad for Nudge, and another pad for Tap-tempo
Jack time slave. Luppp currently only operates as master
Adjustable metronome sound per beat. Usefull for complicated measures
Optional per scene capability: Ability for individual bar measure, tempo, quantization per scene
Probably OT: librubberband for time-stretching of the clips

Some of the features can be implemented separately (rubberband, jack slave), but the others must be done in one redesign of TimeManager. Am I missing more features/aspects?

harryhaaren commented 7 years ago

I presume that the new TimeManager will be able to ramp BPM on the fly? It would be a pity to lose that functionality (even though its currently buggy..)

Agreed that LibRubberband is OT for this rework (so should be a seperate PR) and that JACK time slave is "additional" when done (so can be done later, to avoid having to rework twice).

The main TimeManager and TimeObserver indeed need refactoring in one big bang, please refrain from starting this work until #153 is completed (it will cause any patches no longer apply cleanly).

geraldmwangi commented 7 years ago

"ramp BPM on the fly?": Do you mean change BPM on the fly? Yes, that is a must.

rubberband: I think I want to tackle this one first in a first PR, since I want to have it available ASAP
Time slave: I rethought this. I think slave feature must be done together with the bar/measure stuff, because when in slave mode, luppp receives that info from the time master. At least during the redesign I'll think of the provisions to later implement the slave feature. Maybe a TimeBaseSource class that abstracts jack time base, midi time base, or luppps internal time base. This way the rest of luppp is always in slave mode to the TimeBaseSource, whatever that is!

I'll wait until you give me the o.k. to go!

harryhaaren commented 7 years ago

Just a note that the code-restyle is complete (#153), so building branches on current master will be easy to merge. Commit 01f71ec5e4481f06609b3b4d5f5dfbea676218df is the new code style, including a command to run in order to format code the same as the current codebase.

nanu-c commented 7 years ago

luppp and hydrogen and seq24 are not working well together because of the jack time master, sequentially seq24 crashes and sometimes hydrogen crashes when I try mistakenly to stop the time in one of the two programs but not in luppp

harryhaaren commented 7 years ago

I love the idea of JACK Transport. Unfortunatly its not as easy to implement as it might seem. RE other programs crashing, thats for their bug trackers. RE Luppp not behaving as it should; that is known, and should be addressed by this refactoring work.

Note also that the restlying of the codebase is completed, so theres' nothing (bar time and priority) stopping this work from going ahead :)

geraldmwangi commented 7 years ago

Hi, just for the info: My time plans are a bit delayed. But I'll expect to START the refactoring latest beginning march.

regards Gerald

On 02/02/2017 12:20 AM, Harry van Haaren wrote:

I love the idea of JACK Transport. Unfortunatly its not as easy to implement as it might seem. RE other programs crashing, thats for their bug trackers. RE Luppp not behaving as it should; that is known, and should be addressed by this refactoring work.

Note also that the restlying of the codebase is completed, so theres' nothing (bar time and priority) stopping this work from going ahead :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openAVproductions/openAV-Luppp/issues/152#issuecomment-276815631, or mute the thread https://github.com/notifications/unsubscribe-auth/AHO9dDff7unNuV0EtnnutXtyfM4aEEHbks5rYRNXgaJpZM4LDrXo.

harryhaaren commented 7 years ago

@geraldmwangi - thanks for the update - no stressure (stress / pressure :)

georgkrause commented 7 years ago

Hey @geraldmwangi, how are things going? ;)

geraldmwangi commented 7 years ago

He gcrk,

Stressy as hell. My PhD was revoked by one of the referees. He doesn't like my style of writing . Have to revamp the whole thing:(

And you?

Gerald / JimsonDrift

On 08/03/2017 12:26 PM, Georg Krause wrote:

Hey @geraldmwangi https://github.com/geraldmwangi, how are things going? ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openAVproductions/openAV-Luppp/issues/152#issuecomment-319930977, or mute the thread https://github.com/notifications/unsubscribe-auth/AHO9dIBRBdrY6QFxsEaYXbaNrnXz7_v9ks5sUaBHgaJpZM4LDrXo.

harryhaaren commented 7 years ago

@geraldmwangi ouch - sorry to hear that - Good luck! -H

openAVproductions / openAV-Luppp

Refactoring of TimeManager #152