search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
258 stars 45 forks source link

Save files don't work unless ~/luppp already exists #163

Closed harryhaaren closed 7 years ago

harryhaaren commented 7 years ago

If the ~/luppp directory does not exist, Luppp doesn't save a file. This needs to be fixed asap, should be a small change to ensure that the luppp/ folder exists.

trebmuh commented 7 years ago

Hi @harryhaaren , I think this bug as been reported by one of my (LibraZiK) user. Then, I can propose you to let me know when a fix is found, and I'll be updating the LibraZiK luppp package to check if everything is correct.

harryhaaren commented 7 years ago

@trebmuh - fixed now, I'll be doing a 1.1.1 release to solve this, as it is a critical bug particularly affecting new users of Luppp (as the session dir wouldn't have existed yet).

trebmuh commented 7 years ago

Making a 1.1.1 is a good idea. I've been re-doing a package for LibraZiK for 1.1 + this patch. I think Nico will let you know about is soon.

sub26nico commented 7 years ago

Hi, I have tested this new package in LibraZiK, I tried first to save an an empty project and anything happened, so I recorded a loop then save the project and the ~/luppp had been created with my project. Once the ~/luppp was created, it is possible to save an empty project.

harryhaaren commented 7 years ago

Hi @sub26nico, I can't reproduce the issue here - saving empty sessions, as well as normal sessions seems fine. Would you please re test?

# Please make sure you don't have any Luppp sessions you want to keep here!!
#rm -r luppp
./luppp
# click menu -> Save -> "dirTest"
ls ~/luppp/
# shows the project "dirTest.luppp" directory save file for me

Please also confirm you're testing with the fix version :D [Luppp] main:63: Git: e8b15b3 fix #163; save file dir parent dir created

Thanks, -Harry

sub26nico commented 7 years ago

It's OK, after #rm -r luppp (the folder was deleted in my HOME), I've opened Luppp, and save the empty project, naming it 'dirTest' and the luppp folder is created in my HOME. I don't know what happened the first time. And yes, I'm using the version with the patch, with the new package done by @trebmuh.

harryhaaren commented 7 years ago

Thanks for verifying the fix, and a shout out to Trebmuh for packaging up quickly for testing :D

trebmuh commented 7 years ago

and thanks to you as well to have been that responsive.