search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
259 stars 45 forks source link

Fixes all leaks and adds ASAN compilation #182

Closed napcode closed 7 years ago

napcode commented 7 years ago

Hi,

this PR fixes all leaks I could find. There is also a PR in ntk that fixes a user-after-free that was detected when running luppp with the address sanitizer. An option to compile luppp with this has also been added.

Regards, Mathias

harryhaaren commented 7 years ago

Wow - nice work @napcode. I run Clang with scan-build once in a while - but these additions are the right way to do it! Reviewing..

napcode commented 7 years ago

Sure. Please do.

harryhaaren commented 7 years ago

Thanks to Johnathan for fixing https://github.com/original-male/ntk/pull/8/ quickly, solves the issue mentioned above. Still reviewing :)

napcode commented 7 years ago

Seems like I broke the waveforms. Also, I've found another leak. I guess I'll reopen this.

napcode commented 7 years ago

Hi Harry. Do you still consider merging this pull request or is there something missing?

harryhaaren commented 7 years ago

Hey! I've had little time over the last weeks - and this fell off my radar. Thanks for the ping - I'll get to it at the weekend. Nothing remaining iirc from testing a few weeks ago :) cheers, -Harry

On 19 Jun 2017 21:04, "Mathias Buhr" notifications@github.com wrote:

Hi Harry. Do you still consider merging this pull request or is there something missing?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/openAVproductions/openAV-Luppp/pull/182#issuecomment-309557958, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGgqCLlDYXljF2i6zRi1vxfNOt2VNtyks5sFtRegaJpZM4NFc1A .

harryhaaren commented 7 years ago

Hi @napcode - thanks for this work! Merged now, I done a rebase of the patches just now so this pull wasn't closed automatically. Thanks again! -Harry

napcode commented 7 years ago

Well, thanks for doing all the stuff in the first place (LAC, OpenAV etc.) :-)