openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
258 stars 45 forks source link

Auto Stop Recording #201

Closed vale981 closed 6 years ago

vale981 commented 6 years ago

This little hack uses the beats menu in the context menu to set the maximum beats to record (Rounded up to bars).

If no beat number is set, record works as usual. The beat number is reset upon track reset. Cheers.

coderkun commented 6 years ago

I can confirm that the major feature does not work: The recording doesn’t stop for me but runs endlessly …

georgkrause commented 6 years ago

Its working here with the latest commit in this thread.

vale981 commented 6 years ago

It is working. Please look a the commits. I wouldn't keep that unfixed for days!

vale981 commented 6 years ago

This is one of the last days I am able to work on this as my semester is going to start very soon.

If there are there are any wishes. Voice them now.

georgkrause commented 6 years ago

If you changed everything Harry requested this should be fine. Please be patient ;)

If you want you could add comments for the doxygen documentation to your code

coderkun commented 6 years ago

I can confirm that the feature is working (again). Would be good to squash the commits though.

vale981 commented 6 years ago

Sorry for all the whitespace issues. I was lazy and should have limited that script to the files I changed. Nevertheless I endorse clang-format as it is a good way to keep the style consistent, even with devs who ain't use no tabs anywhere in their system.

vale981 commented 6 years ago

Well I actually can't tell why I haven't looked at the diffs.

vale981 commented 6 years ago

I'll close this for now.

georgkrause commented 6 years ago

Will you file another PR with this functionallity?

vale981 commented 6 years ago

A squashed one probably

georgkrause commented 6 years ago

@vale981 i hope so, if not i could also port this feature. Keep us updated!