Closed vale981 closed 6 years ago
I can confirm that the major feature does not work: The recording doesn’t stop for me but runs endlessly …
Its working here with the latest commit in this thread.
It is working. Please look a the commits. I wouldn't keep that unfixed for days!
This is one of the last days I am able to work on this as my semester is going to start very soon.
If there are there are any wishes. Voice them now.
If you changed everything Harry requested this should be fine. Please be patient ;)
If you want you could add comments for the doxygen documentation to your code
I can confirm that the feature is working (again). Would be good to squash the commits though.
Sorry for all the whitespace issues. I was lazy and should have limited that script to the files I changed. Nevertheless I endorse clang-format as it is a good way to keep the style consistent, even with devs who ain't use no tabs anywhere in their system.
Well I actually can't tell why I haven't looked at the diffs.
I'll close this for now.
Will you file another PR with this functionallity?
A squashed one probably
@vale981 i hope so, if not i could also port this feature. Keep us updated!
This little hack uses the beats menu in the context menu to set the maximum beats to record (Rounded up to bars).
If no beat number is set, record works as usual. The beat number is reset upon track reset. Cheers.