search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
257 stars 45 forks source link

Travis CI #270

Closed georgkrause closed 5 years ago

georgkrause commented 5 years ago

This enables and configures Travis CI for Luppp. It does not run tests for now since they sometimes try to open windows, which wont work.

I still get:

[1/42] Generating version.hxx with a custom command.
fatal: No names found, cannot describe anything.

This is because we can't read the git information in Travis...

Build Status

harryhaaren commented 5 years ago

Hey Georg, thanks for setting this up! I presume this is working towards getting Travis running on each PR / commit? If yes, is it ready to enable now, or is there more to do first?

georgkrause commented 5 years ago

Well, I am not really sure if this will run on each PR, but should run for each commit in each branch in this repository. One would need to activate this, though. But it seems like I can do this.

Honestly I am not really experienced with Travis and this is more try an error. Since its unlikely to break something I would just merge this and see what happens and fix stuff if needed. If this wont work for you, I can dig into the documentation to get how to enable PR builds.

In general to make this really useful we should have some nicely implemented Unit Tests. But for now this does not seem a good spend of time since the code is really tight coupled and therefor its hard to setup something which does not rely on the GUI...

harryhaaren commented 5 years ago

Ah ok, well this stuff is enabled for Ctlra repo already (https://github.com/openAVproductions/openAV-Ctlra/blob/master/.travis.yml) , so I should be able to get it to work for Luppp too :)

Yes agree that the current code is very hard to test due to tight coupling - indeed this shows that I was a novice at sw architecture when Luppp was initially created. Currently WIP OpenAV projects are a lot more modular than this version of Luppp - so the good news is that this has been addressed in more recent OpenAV software.

georgkrause commented 5 years ago

Absolutely no blame intended, I just wanted to justify not configuring any tests (not even the few which are available)

harryhaaren commented 5 years ago

Understood - and agreed. I'll try find some time over the weekend to poke the github settings to enable Travis with this PR. Thanks!

georgkrause commented 5 years ago

This should now create an appdir which is needed for the planned AppImage

georgkrause commented 5 years ago

Thanks to @probonopd, Travis also builds an AppImage and loads it into Github Releases as discussed here #237. (already tested and ready to merge)

georgkrause commented 5 years ago

Some information here: https://github.com/georgkrause/openAV-Luppp/pull/2

harryhaaren commented 5 years ago

All looks good to me folks, looks like it needs a rebase, then I'm happy for you to merge @georgkrause.

georgkrause commented 5 years ago

@harryhaaren Rebase is done. Should be ready to merge now. Please note the needed Travis configuration...

harryhaaren commented 5 years ago

Thanks folks!