search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
256 stars 43 forks source link

Send volume changes to controller #310

Open wvengen opened 4 years ago

wvengen commented 4 years ago

Ad this moment, the volume sliders can not send midi changes. This is relevant for controllers with motorized faders and led-based (rotary or fader) controls.

Some controllers can also gradually change the volume, which doesn't work when volume changes sent by the controller are sent back to it. That's why this needs to be controlled as well.

This PR adds midi messages for all volume/pan/send midi events, and the ability to toggle echo for these messages. Tested on the Launchpad X (#309).

harryhaaren commented 3 years ago

@wvengen, any opens around this? Anything I can do in 30 mins to move it along? (And my apologies that I haven't been working on this stuff at all in recent months - but that's real life for me atm : )

wvengen commented 3 years ago

Hi @harryhaaren thank you for your response! I'd love to get the PRs merged (even if it will take a while, also from my side). If you could take a first look at the code and indicate the most important things to address, that would help. And also hear if you'd prefer the use of Event::SOURCE or SOURCE.