search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
258 stars 45 forks source link

Metronome in the Background of Every Sample #95

Closed mynameisnate closed 9 years ago

mynameisnate commented 9 years ago

First I would like to say that this project is amazing. I found it two day ago and love it.

On to my problem. Everytime I record audio or even route the audio through luppp I get a clicking sound in the background. The click is the same tempo as the metronome but they don't sound the same and even when I off the metronome these clicks are still there. However, the clicks only happen when the loops are playing or I am holding a note from Yoshimi (or hydrogen, etc.) and routing it through luppp. In other words when there is no music there is no click. Maybe I am just making a stupid mistake and it is a simple fix.

Thanks for your help!

mynameisnate commented 9 years ago

Oh I forgot to say I got luppp off the AUR.

harryhaaren commented 9 years ago

Hi @mynameisnate, glad you like it.

Thanks for reporting this issue: the good news: I experience it here too, so I can debug and troubleshoot the issue myself and once I understand it, fix it!

The bad news is that unfortunatly its not a "simple" error where the metronome is mixed into the (passtrough) Yoshimi-signal, but a more complex one of how Luppp handles time.

I've checked the code the last 1/2 an hour, I'm understanding it better as time goes on. I hope to fix this: I understand its a critical issue.

Cheers, -Harry

PS: Mini update: I can remove the split processing of before / after a beat, and the issue is gone, so I know exactly what the problem is now. Lunch, then I'll try find the fix for this.

mynameisnate commented 9 years ago

Thanks for the mini update, hope the fix is coming along well.

harryhaaren commented 9 years ago

Hi @mynameisnate, thanks for the reminder on fixing this.

Please get the latest git, i've disable the master-return ports, and swapped some buffers, the issue is no longer present. The bug goes deeper than this fix: so I'm opening a new issue for the "real thing".

Please confirm fixed :) Cheers, -Harry

harryhaaren commented 9 years ago

Reopening, having loops in the tracks now clicks, although it don't click on the input audio anymore.

harryhaaren commented 9 years ago

Closing, moved to #96 .