openBackhaul / MicroWaveDeviceInventory

Physical and logical inventory of the MW SDN Domain
Apache License 2.0
5 stars 1 forks source link

Required attributes for /v1/regard-device-object-creation #833

Closed nardecchia-siae closed 7 months ago

nardecchia-siae commented 7 months ago

There is a mismatch in required attributes between Notification Proxy and MWDI for the device object creation notification api.

In notification proxy yaml, for object creation below are the attributes required to the subscriber sending information.

NP: required:

But MWDI yaml spec is having extra attribute “object-type” for API:/v1/regard-device-object-creation.

Because of this, validation of object creation notification is getting failed.

MWDI: required:

openBackhaul commented 7 months ago

Please, be invited to implement according to your preference (with or without object-type attribute) and document your decision here, so we can rectify the specification.

nardecchia-siae commented 7 months ago

The object-type attribute can be removed as required object from specification as it is not used in the implementation of the related api.

kmohr-soprasteria commented 7 months ago

Removed the object-type from list of required attributes; kept it as optional attribute.

openBackhaul commented 7 months ago

Stringently removed the object-type attribute from all ObjectCreationNotifications.