openBackhaul / MicroWaveDeviceInventory

Physical and logical inventory of the MW SDN Domain
Apache License 2.0
5 stars 1 forks source link

[ConvenienceServices] Error responses inconsistent #886

Open kmohr-soprasteria opened 7 months ago

kmohr-soprasteria commented 7 months ago

The error responses are inconsistent; if an unknown link-id/device-name is passed in the requestBody:

  1. /v1/provide-list-of-parallel-links: returns 500 (pic1)
  2. /v1/provide-list-of-device-interfaces: return code is 200, but code in the message is 404 (pic2)
  3. /v1/provide-list-of-actual-device-equipment (pic3)

The responseCodes are not aligned between both services and for (2, 3) the responseCode does not match the code given in the responseBody.

For cache services I see 500, "unable to fetch records..." which is aligned across the cache responses I checked, but again not aligned with services above (pic4/5).

We anyway should align error responses across the various applications, but still it should be at least aligned across services in a single application.

Pic Example
1 image
2 image
3 image
4 image
5 image
nardecchia-siae commented 7 months ago

To be tested in tag test_v1_1_4