openBackhaul / MicroWaveDeviceInventory

Physical and logical inventory of the MW SDN Domain
Apache License 2.0
5 stars 1 forks source link

To correct the originator for the API call to NotificationProxy #905

Closed PrathibaJee closed 4 months ago

PrathibaJee commented 5 months ago

While addressing the request /v1/notify-controller-attribute-value-changes to NotificationProxy , the originator of that request should be "MicroWaveDeviceInventory" But , as of now , the originator is "RegistryOffice" which is misleading while analyzing the traces.

Proposing to change the originator as "MicroWaveDeviceInventory"

callback : POSThttp://x.x.x.x:3009/v1/notify-controller-attribute-value-changes header :{"user":"User Name","originator":"RegistryOffice","x-correlator":"120e8477-e29b-11d4-a716-446655441652","trace-indicator":"1.1.1.1.1","customer-journey":"Unknown value","operation-key":"Operation key not yet provided.","Content-Type":"application/json"}body :{"subscribing-application-name":"MicroWaveDeviceInventory","subscribing-application-release":"1.1.0","subscribing-application-protocol":"HTTP","subscribing-application-address":{"ip-address":{"ipv-4-address":"x.x.x.1"}},"subscribing-application-port":3008,"notifications-receiving-operation":"/v1/notify-controller-attribute-value-changes"}response code:204

The problem is there for the following 5 API calls, /v1/notify-controller-attribute-value-changes /v1/notify-device-alarms /v1/notify-device-attribute-value-changes /v1/notify-device-object-creations /v1/notify-device-object-deletions

PrathibaJee commented 4 months ago

Issue is fixed in the version 1.1.0.a_impl. In this latest package , originator for the mentioned callbacks are MicroWaveDeviceInventory as expected. hence closing this issue.

Logs (for manually triggered Embed-yourself)

"[
  {
    "x-correlator": "330e8400-e29b-11d4-a716-446655441234",
    "trace-indicator": "1",
    "user": "Prathiba",
    "originator": "Prathiba",
    "application-name": "MicroWaveDeviceInventory",
    "release-number": "1.1.0",
    "operation-name": "/v1/embed-yourself",
    "response-code": 204
  },
  {
    "x-correlator": "330e8400-e29b-11d4-a716-446655441234",
    "trace-indicator": "1.1",
    "user": "Prathiba",
    "originator": "MicroWaveDeviceInventory",
    "application-name": "NotificationProxy",
    "release-number": "1.0.1",
    "operation-name": "/v1/notify-controller-attribute-value-changes",
    "response-code": 204
  },
  {
    "x-correlator": "330e8400-e29b-11d4-a716-446655441234",
    "trace-indicator": "1.2",
    "user": "Prathiba",
    "originator": "MicroWaveDeviceInventory",
    "application-name": "ApplicationLayerTopology",
    "release-number": "2.0.1",
    "operation-name": "/v1/update-ltp",
    "response-code": 204
  },
  {
    "x-correlator": "330e8400-e29b-11d4-a716-446655441234",
    "trace-indicator": "1.2",
    "user": "Prathiba",
    "originator": "MicroWaveDeviceInventory",
    "application-name": "NotificationProxy",
    "release-number": "1.0.1",
    "operation-name": "/v1/notify-device-alarms",
    "response-code": 204
  },
  {
    "x-correlator": "330e8400-e29b-11d4-a716-446655441234",
    "trace-indicator": "1.3",
    "user": "Prathiba",
    "originator": "MicroWaveDeviceInventory",
    "application-name": "NotificationProxy",
    "release-number": "1.0.1",
    "operation-name": "/v1/notify-device-attribute-value-changes",
    "response-code": 204
  },
  {
    "x-correlator": "330e8400-e29b-11d4-a716-446655441234",
    "trace-indicator": "1.4",
    "user": "Prathiba",
    "originator": "MicroWaveDeviceInventory",
    "application-name": "NotificationProxy",
    "release-number": "1.0.1",
    "operation-name": "/v1/notify-device-object-creations",
    "response-code": 204
  },
  {
    "x-correlator": "330e8400-e29b-11d4-a716-446655441234",
    "trace-indicator": "1.5",
    "user": "Prathiba",
    "originator": "MicroWaveDeviceInventory",
    "application-name": "NotificationProxy",
    "release-number": "1.0.1",
    "operation-name": "/v1/notify-device-object-deletions",
    "response-code": 204
  }
]"