openBackhaul / MicroWaveDeviceInventory

Physical and logical inventory of the MW SDN Domain
Apache License 2.0
5 stars 1 forks source link

/core-model-1-4:network-control-domain=cache/link={uuid}/link-port={local-id} - error response message for unknown NEs needs to be changed #969

Closed kmohr-soprasteria closed 2 months ago

kmohr-soprasteria commented 5 months ago

If the cache doesn't contain data for the combination of uuid/local-id the service returns a 404 for both GET and DELETE, which is correct. However the responseMessages need to be modified, as they currently both return "unable to fetch records for link >uuid<".

They should be changed as follows:

Ziabatcha commented 4 months ago

Tested with latest package 1.1.2e, Issue still persist.

observing Null response when trying to GET a link port that doesnt exists.

http://xxx:xxx/core-model-1-4:network-control-domain=cache/link=513250008/link-port=3

{
  "core-model-1-4:link-port": [
    null
  ]
}
observing 204 RESPONSE when trying to DELETE a link port that doesnt exists.

http://xxx:xxx/core-model-1-4:network-control-domain=cache/link=513250008/link-port=4

Response:
access-control-allow-origin: * 
 connection: keep-alive 
 date: Wed, 19 Jun 2024 06:09:48 GMT 
 keep-alive: timeout=5 
 x-powered-by: Express
kmohr-soprasteria commented 2 months ago

MWDI should return default messages for standard responseCodes. This will be aligned with 1.1.3, therefore closed