search

openBackhaul / OperationKeyManagement

Manages keys required for consuming services between applications
Apache License 2.0
3 stars 8 forks source link

Instead of triggering /v1/dispose-remainders-of-deregistered-application , subscription shall be removed for unsuccessful regard-applications #350

Open PrathibaJee opened 4 months ago

PrathibaJee commented 4 months ago

If OKM could not able to regard an application due to any internal failure , then as of now OKM will send /v1/dispose-remainders-of-deregistered-application Reason : To ensure that OKM is not sending update-operation-keys to the regarded application's operation-server. This is modelled so.

Problem : Incase if the regarded application is one of the TAC and OKM has invariant forwardings for this application. Then disposal deletes the http-client resulting in non-functioning of the invariant forwardings.

Proposals : Proposal#1: For all the application , if it is not regarded successfully , then instead of disposing that application , end-subscription shall be initiated to delete the fc-port from the following forwardings,

  1. LinkUpdateNotificationCausesOperationKeyUpdates
  2. CyclicOperationCausesOperationKeyUpdates

Proposal#2: If there is any invariant forwardings available for the regarded application , then rollback shall not initiate /v1/dispose-remainders-of-deregistered-application , internally it shall delete the subscription from the following forwardings,

  1. LinkUpdateNotificationCausesOperationKeyUpdates
  2. CyclicOperationCausesOperationKeyUpdates
PrathibaJee commented 3 months ago

Temporarily this issue is fixed in the PR https://github.com/openBackhaul/OperationKeyManagement/issues/334. Since the provided proposals add complexity , this issue shall be analyzed deeply in the future releases to provide a simple and transparent solution.

Related issue : https://github.com/openBackhaul/OperationKeyManagement/issues/309