openBackhaul / RegistryOffice

Apache License 2.0
2 stars 8 forks source link

Wrong keywords in forwardingList? #390

Closed kmohr-soprasteria closed 1 year ago

kmohr-soprasteria commented 1 year ago

I noticed that in the forwarding list there are keywords "server-name" and "service-name". In the template from the ApplicationPattern I only see "server-name", so I guess this might be wrong as I would expect this should be "server-name" everywhere...

Example:

  - forwarding-name: ServiceRequestCausesFcUpdateRequest
    uuid: ro-2-0-1-op-fc-bm-008
    forwarding-type: InvariantProcessSnippet
    management-requests:
      operation-client-update:
        - server-name: /v1/redirect-topology-change-information
          uuid: ro-2-0-1-op-s-bm-009
      fc-port-update:
        - server-name: /v1/redirect-topology-change-information
          uuid: ro-2-0-1-op-s-bm-009
      fc-port-deletion:
      operation-client-deletion:
    initiating-requests:
      - service-name: /v1/register-application
        uuid: ro-2-0-1-op-s-is-001
      - service-name: /v1/regard-updated-approval-status
        uuid: ro-2-0-1-op-s-is-003
      - service-name: /v1/notify-deregistrations
        uuid: ro-2-0-1-op-s-is-007
      - service-name: /v1/notify-approvals
        uuid: ro-2-0-1-op-s-is-008
      - service-name: /v1/notify-withdrawn-approvals
        uuid: ro-2-0-1-op-s-is-009
    consequent-requests:
      - client-name: ApplicationLayerTopology://v1/update-fc
        uuid: ro-2-0-1-op-c-bm-alt-1-0-0-003
IswaryaaS commented 1 year ago

@kmohr-soprasteria , you are correct, somehow it could have been mixed. It would be "server-name" and not "service-name".

Similar issues : https://github.com/openBackhaul/TypeApprovalRegister/issues/202 https://github.com/openBackhaul/ExecutionAndTraceLog/issues/221 https://github.com/openBackhaul/OamLog/issues/212 https://github.com/openBackhaul/AdministratorAdministration/issues/206 https://github.com/openBackhaul/ApplicationLayerTopology/issues/308 https://github.com/openBackhaul/OperationKeyManagement/issues/195

openBackhaul commented 1 year ago

Changed as proposed. Changed committed into ro_v2.0.2_spec branch.