openBackhaul / RegistryOffice

Apache License 2.0
2 stars 8 forks source link

/v1/register-application service implementation to be updated in test suite for protocol update. #482

Closed vanithavalluripalli9 closed 10 months ago

vanithavalluripalli9 commented 1 year ago

In the test suite run the below mentioned test cases are failing :

/v1/register-application::Attribute configured? / tcp-server-list updated? / protocol updated? :

/v1/register-application::Update LTP notified? / tcp-server-list update notified? / protocol update

Problem Description : In case of RO , as multiple tcp-clients are allowed , a new tcp-c will be formulated for HTTPS instead of replacing existing tcp-c instance while we are updating protocol from HTTP to HTTPS based on the tcp-server list.

So, in test suite while updating the protocol from HTTP to HTTPS , we have to check whether new instance of protocol is being created instead checking whether existing instance is only being updated.

Similar Issue : https://github.com/openBackhaul/ApplicationPattern/issues/806

PrathibaJee commented 1 year ago

Assertion failure details In RO Individual Services , following are the assertions that are failed because of this problem,

  1. /v1/register-application:: Attribute configured? / tcp-server-list updated? / protocol updated? - count 2
  2. /v1/register-application:: Update LTP notified? / tcp-server-list update notified? / protocol update :: Check /core-model-1-4:control-construct

Reason : While updating the protocol from HTTP to HTTPS test suite is checking for updation of protocol instead of cheking whether any new tcp-c is formulated.

IswaryaaS commented 10 months ago

As per https://github.com/openBackhaul/ApplicationPattern/issues/549#issuecomment-1741967061, only one tcp-client is allowed for an application. hence closing this issue. @vanithavalluripalli9 , kindly reopen the issue if my understanding is conflicting or create a new issue in impl (if not created) for this concept. Thank you.