openBackhaul / RegistryOffice

Apache License 2.0
2 stars 8 forks source link

Clarification regarding the callback ApprovalNotification #539

Closed PrathibaJee closed 9 months ago

PrathibaJee commented 10 months ago

we have the forwarding ApprovalNotification (to broadcast approval) which is marked as deprecated and will be removed in version 3.0.0.

In the version 2.1.0 of RegistryOffice, there is an ApprovingApplicationCausesConnectingWith sequence. In this ApprovingApplicationCausesConnectingWith forwardings ,
the new approved application will be connected to ALT , OKM , EATL , AA , OL applications in a sequence.

Clarification required : Kindly please clarify ,

  1. whether this "ApprovalNotification" forwarding will be performed in parallel to the ApprovingApplicationCausesConnectingWith forwarding ?
  2. or we will not perform this forwarding ?
openBackhaul commented 9 months ago

It makes no sense to mark forwarding ApprovalNotification as deprecated.

In general, the former subscription based concept has been turned into a fixed process concept. The fixed process is covering the known applications of the TAC.

Two options: 1) The forwarding ApprovalNotification could be deleted. In regard of backward compatibility: Incoming requests at RO://v1/notify-approvals would be ignored, which doesn't matter, because all existing applications are covered by the fixed process. 2) The forwarding ApprovalNotification could be left as is, because there could be future applications that require such notification, but are not covered by the fixed process.

Deleting forwarding ApprovalNotification means also future TAC applications need to be covered by the fixed process. This would mean: No future TAC application without changing the RegistryOffice. That would be the end of modularity.

Alternative proposal: Putting the broadcast to the end of the fixed process.

Proposed changes:

PrathibaJee commented 9 months ago

Thanks for the detailed explanation. As discussed , "Alternative proposal: Putting the broadcast to the end of the fixed process." would be fine, as it supports future TinyApplicationController applications to receive notifications about the new approved applications.

openBackhaul commented 9 months ago

Changed as proposed in comment above.