search

openBackhaul / RegistryOffice

Apache License 2.0
2 stars 8 forks source link

To make the ApprovingApplicationCausesConnectingWith sequence backward compatible #540

Closed PrathibaJee closed 8 months ago

PrathibaJee commented 9 months ago

In the version 2.1.0 of RegistryOffice, there is an ApprovingApplicationCausesConnectingWith sequence.

This ApprovingApplicationCausesConnectingWith sequence will work fine if all the TAC applications are >= version 2.1.0 and their /v1/regard-application API produces a response-body that consists of attribute "successfully-connected" that indicates the status of the connection.

This ApprovingApplicationCausesConnectingWith sequence will not work , if any one of the TAC application is not < 2.1.0.

Proposal : Proposing the following to make this ApprovingApplicationCausesConnectingWith sequence backward compatible ,

  1. If the response of /v1/regard-application is 204 , that means , the serving application is < 2.1.0.
  2. So , for this RegistryOffice version 2.1.0 , we shall skip the steps in validating the response of /v1/regard-application if the response-code is 204 and move to the next sequence.
  3. Later in RegistryOffice version 3.0.0 , we shall remove this exceptions.
openBackhaul commented 8 months ago

I would rather prefer to keep the period of TAC applications being on different releases as short as possible (respectively, not to register any other new application during that period) than to introduce another if-then-else that later has to be removed again.

Would you see any significant disadvantage from this ignorant position?

openBackhaul commented 8 months ago

The TAC applications are together to be put into operation within a short period of time. In the period between the commissioning of the first and the last application of the TAC, no other applications should be put into operation.

PrathibaJee commented 8 months ago

Similar to the decision made in https://github.com/openBackhaul/RegistryOffice/issues/541#issuecomment-1908091299 , if there is a problem in the ApprovingApplicationCausesConnectingWith sequence , then that problem will be reported to TypeApprovalRegistry. After manually resolving the problem , manually the embedding status shall be updated by an administrator by using the new feature defined in the TAR issue openBackhaul/TypeApprovalRegister#299. Hence closing this issue.