openBackhaul / TypeApprovalRegister

Administrates the list of approvals of Applications.
Apache License 2.0
1 stars 8 forks source link

To remove response header parameter BackendTime for failed request #393

Closed IswaryaaS closed 1 month ago

IswaryaaS commented 2 months ago

As per https://github.com/openBackhaul/ApplicationPattern/issues/903. backendTime shall be removed from responseHeader of negative responses.

To achieve the same, a minor change has been made in https://github.com/openBackhaul/ApplicationPattern/pull/1011.

Additionally, in Controllers/BasicServices.js and Controllers/IndividualServices.js file, "-1" shall be used in last placeholder in below line in catch block for all services

let responseHeader = await RestResponseHeader.createResponseHeader(xCorrelator, startTime, req.url, -1);

image

IswaryaaS commented 1 month ago

the solution is not applied to BasicServices.js/embedYourself . @sunil-kumar-meena , please update the code and raise a PR for the same. Thanks