search

openBackhaul / core

Core Information Model that consolidates all technology specific extension
Apache License 2.0
1 stars 0 forks source link

forwarding-construct/fc-port with wrong min-elements #2

Closed michbin closed 4 years ago

michbin commented 5 years ago

The fc-port list in the forwarding-construct grouping is defined with min-elements 2, i.e. must have at least 2 elements. This is not true for Forwarding Constructs which represent VLANs. They are usually created without member ports which are added afterwards.

demx8as6 commented 5 years ago

For VLAN purposes I would agree that an "empty" VLAN should be represented as "empty" ForwardingConstuct. A solution could be: by "pruning-and-refactoring" the min-elements as defined in CoreModel.UML could be "corrected".

@openBackhaul: please comment.

demx8as6 commented 5 years ago

Decision made on the ONF call: https://wiki.opennetworking.org/display/OTCC/2019-10-30+5G-xHaul+Meeting+Notes

Change min-elements from 2 to 0.

demx8as6 commented 5 years ago

Please retest once a new core-model was delivered. open-backhaul-issue2

openBackhaul commented 4 years ago

Minimum number of elements changed to 0. Issue can be closed.

 list fc-port {
      key "local-id";
      min-elements 0;
      uses fc-port;
      description
        "The FcPorts define the boundary of the FC.
         The FC is accessed via the FcPorts.
         Flow within the FC is defined in terms of its FcPorts.";
    }
openBackhaul commented 4 years ago

For avoiding warnings during compilation the "min-elements 0;" statement has been removed.

RFC7950: "If no "min-elements" statement is present, it defaults to zero."