search

openBackhaul / core

Core Information Model that consolidates all technology specific extension
Apache License 2.0
1 stars 0 forks source link

global-class: name with unexpected min-elements #3

Closed michbin closed 4 years ago

michbin commented 5 years ago

The name list in the global-class grouping has a min-elements: 1 constraint which is enforced when objects are created (e.g. an fc-port in an fc).

I would not have expected the constraint because the objects defined in the Core Model are uniquely identified by either the uuid or the local-id attribute. They may or may not have additional name attributes.

demx8as6 commented 5 years ago

Status:

Such a model for a name in a device model is at least questionable. There is the possibility to prune-and-refactor the core-model. - I would suggest that in the end there is the same model in yang as it was for core-model 1.2.

@openBackhaul : please comment.

demx8as6 commented 4 years ago

Decision made on the ONF call: https://wiki.opennetworking.org/display/OTCC/2019-10-30+5G-xHaul+Meeting+Notes

Change min-elements from 1 to 0.

demx8as6 commented 4 years ago

Please retest once a new core-model was delivered.

open-backhaul-issue3

openBackhaul commented 4 years ago

Minimum number of names has been changed to 0. Issue can be closed.


  grouping name {
    list name {
      key "value-name";
      min-elements 0;
      uses name-and-value;
      description
        "List of names.";
    }
openBackhaul commented 4 years ago

For avoiding warnings during compilation the "min-elements 0;" statement has been removed.

RFC7950: "If no "min-elements" statement is present, it defaults to zero."