search

openBackhaul / synchronization

Synchronization model according to ITU-T G.7721-2018
Apache License 2.0
1 stars 0 forks source link

Inconsistent definition of "ptp-default-dataset/clock" #21

Open michbin opened 2 years ago

michbin commented 2 years ago

The meaning and definition of the clock attribute in the ptp-default-dataset container are not clear.

Since ptp-default-dataset (indirectly) augments the clock class, i.e. is part of a clock object, there is no need for a reference to the clock object (and definitely not to an embedded clock).

If it represents the clock identity then it is a duplicate of ptp-clock-identity and thus redundant.

openBackhaul commented 2 years ago

The CLK ID attribute is most probably translating into localClockId : ClockIdentity, which seems to be redundant with ptpClockIdentity (read-only) in the ptpSynch_Pac.

In IEEE 1588 the localClockId is in the PtpDefaultDataset, but seem to be read-only instead of read/write as stated in the 7721.

Need technology specific expert to advice

openBackhaul commented 2 years ago

Changes made on the Modelling call on 26th of April 2022: _clock attribute has been deleted from PtpDefaultDataset datatype. clockIdentity attribute has been moved from PtpSync_Pac to PtpDefaultDataset. clockIdentity attribute has been renamed to localClockIdentity and got the comment "Identifier of the “physical” local clock."