Replacing restart-pmd-negotiation-is-on by RPC

openBackhaul / wireInterface

Technology specific interface definition for Ethernet PHY interfaces according to IEEE 802.3

Apache License 2.0

2 stars 1 forks source link

Replacing restart-pmd-negotiation-is-on by RPC #35

Closed openBackhaul closed 2 years ago

openBackhaul commented 3 years ago

restart-pmd-negotiation-is-on is not a configurable attribute (which would have an administrative and an operational state), but initiation of a negotiation operation on the device.

Potentially, it would be better to replace the attribute by an RPC definition.

demx8as6 commented 3 years ago

RPC seams to be the better operation for such case. we may need to have similar cases in other interfaces (clear-something, ....)

openBackhaul commented 2 years ago

Proposal to the 5G-xhaul call on 18th of August 2021:

create WireInterfaceOperations Interface with comment: "Group of operations, which are effective on an already existing WireInterface."
create a WireInterfaceOperations::restartPmdNegotiation( in _affectedWireInterface:LogicalTerminationPoint ) operation
- with comment: "Restarts the PMD auto negotiation process on the referenced WireInterface. The following error-message is to be send, if the operation would fail: #[onf:Referenced object is invalid.]#, if the referenced LogicalTerminationPoint does not exist or does not belong to the Wire layer."
- and isOperationIdempotent==true isAtomic==true.
delete existing WireInterfaceConfiguration::restartPmdNegotiationIsOn : Boolean = false attribute

PrathibaJee commented 2 years ago

Since the UML2YANG tool doesn’t have the capability to translate the UML artifacts “idempotent” and “atomic” into corresponding Yang modelling , we have to complement it in the comment(description) field of the operation.

openBackhaul commented 2 years ago

Decision at the 5G-xhaul call on 18th of August 2021:

create WireInterfaceOperations Interface with comment: "Group of operations, which are effective on an already existing WireInterface."
create a WireInterfaceOperations::restartPmdNegotiation( in _affectedWireInterface:LogicalTerminationPoint ) operation
- with comment: "Restarts the PMD auto negotiation process on the referenced WireInterface. The following error-message is to be send, if the operation would fail: #[onf:Referenced object is invalid.]#, if the referenced LogicalTerminationPoint does not exist or does not belong to the Wire layer."
- and isAtomic==true.
delete existing WireInterfaceConfiguration::restartPmdNegotiationIsOn : Boolean = false attribute

openBackhaul commented 2 years ago

Solved with WireInterface_2.0.0-tsp.220314.1810 release.