small Style Changes to the UI

openDsh / dash

Join us on Slack! https://join.slack.com/t/opendsh/shared_invite/zt-la398uly-a6eMH5ttEQhbtE6asVKx4Q

GNU General Public License v3.0

238 stars 69 forks source link

small Style Changes to the UI #108

Open Tysonpower opened 2 years ago

Tysonpower commented 2 years ago

Description:

Made some small padding changes etc. to make the UI look a bit nicer.

Checklist:

[x ] The code change is tested and works locally.

rsjudka commented 2 years ago

you mind adding some screenshots of the changes? don't have access to my PC but if they look good i can merge it in

Tysonpower commented 2 years ago

here is a quick screenshot, added padding at the top tab bar as well as the file selector

Tysonpower commented 2 years ago

@rsjudka please merge

rsjudka commented 2 years ago

oh sorry thought i responded!

im okay with the fixes to the list widget, but the padding for the tab bar might be a bit much (especially for those with lower resolutions - sorry for the callout but @icecube45 what do you think of that?)

icecube45 commented 2 years ago

The vertical padding of the tab bar? Agreed on it being excessive. It's about a quarter (maybe a fifth) of the vertical display on the resolution I'm working with, pretty big increase from previous.

I'll try to test it on the actual car display though, to see how it works out on there.

Tysonpower commented 2 years ago

what size of car display is that? That is really really really small :)

akhil11naseem commented 1 year ago

I am building this for my motorcycle to replace mounting my phone on the handlebar. So I am using a small 4.3" 480x800 waveshare display. So excessive padding would make it difficult to use in my use case.