search

openDsh / dash

Join us on Slack! https://join.slack.com/t/opendsh/shared_invite/zt-la398uly-a6eMH5ttEQhbtE6asVKx4Q
GNU General Public License v3.0
238 stars 69 forks source link

Add build dir for aasdk and openauto in install.sh #37

Closed ZeroErrors closed 3 years ago

ZeroErrors commented 3 years ago

Change Log

Description

Feel free to close this PR if there is a valid reason not to have this. Based on some searching it seems this did exist before at one point as it was introduced in the commit https://github.com/openDsh/dash/pull/6/commits/5b2aec930c1622afc87b4931814f296dd46e58a5 as part of the PR https://github.com/openDsh/dash/pull/6 but then was later removed in https://github.com/openDsh/dash/pull/12 but doesn't have any explanation of why, so if there is a reason then I'd like for this PR to at least serve as documentation for why that is.

However, I have tested the install script with these changes have been using it to make it easier to recompile openauto by clearing its build directory after making environmental changes. I haven't run into any issues but also only have one environment to test in so if some others can test it out that would be great.

Checklist:

icecube45 commented 3 years ago

I believe the pages branch (which has a pending PR) has a build directory for dash.

icecube45 commented 3 years ago

wait sorry, I misread this - aasdk and openauto do not, so yes, this is a good idea.

rsjudka commented 3 years ago

yeah i remember requesting this in the original pr, but it ended up breaking something... somewhere

its vaguely familiar to me, but ill divert to @rhysmorgan134

rhysmorgan134 commented 3 years ago

Yeah I also remember doing it like this originally, I believe it was something to do with when we moved from intelligent auto building to the new dash way, I can't remember who, but suggested it not be done that way. It's come a long way since then, so if it builds, it makes sense to me.