openDsh / dash

Join us on Slack! https://join.slack.com/t/opendsh/shared_invite/zt-la398uly-a6eMH5ttEQhbtE6asVKx4Q
GNU General Public License v3.0
259 stars 80 forks source link

Updated install script to work with openDsh #6

Closed rhysmorgan134 closed 4 years ago

rhysmorgan134 commented 4 years ago

Script now beings in dash, then clones the 3 required directories as peers of dash. Then runs through the process to install them all. Added arguments to choose what part of the script will run

example will only install dependencies, openauto and dash. ./install.sh --deps --openauto --dash

egisz commented 4 years ago

HI, Installing on clean / updated Raspbian Buster, I get error:

[100%] Linking CXX executable ../bin/autoapp
/usr/bin/ld: cannot find -lomx
collect2: error: ld returned 1 exit status
make[2]: *** [autoapp/CMakeFiles/autoapp.dir/build.make:188: bin/autoapp] Error 1
make[1]: *** [CMakeFiles/Makefile2:270: autoapp/CMakeFiles/autoapp.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
make err`or check logs
rhysmorgan134 commented 4 years ago

@egisz apologies, it was still looking at the original fork, updated now to look at one with the fix, should work now

egisz commented 4 years ago

Thanks @rhysmorgan134, now it works. Probably it would be best to to create another PR for openauto Repo with your fixes. And then fix this script to point to original Repo. What do you think?

rhysmorgan134 commented 4 years ago

Thanks @rhysmorgan134, now it works. Probably it would be best to to create another PR for openauto Repo with your fixes. And then fix this script to point to original Repo. What do you think?

Yeah, the issue was brought up in slack, @icecube45 mentioned that its most likely something else going on. I'm not great with C++, so hopefully one of the guys can look into it, (I still need to triple check that all dependencies are correct and its not an issue on my side thats not showing as its not doing an OMX build)

This PR is in draft, I won't submit it until this is resolved in which way it requires.

egisz commented 4 years ago

You may already know, but I'd like to point out that Crankshaft contains prebuilds scripts for same things. Maybe worth to reuse? There also is qt build script which may also be useful, what do you think?