AA auto full screen

[egisz]

Description:

• Added setting for automatic switch to full screen mode when AA is connected.
• If setting is ON, AA switch to full screen when connected.
• Dash switch to non full screen when device disconnects.

fixes #27

Checklist:

• [X] The code change is tested and works locally.

[rsjudka]

lgtm! ill let some ppl test it out to see how they feel about the flow

[egisz]

I was hesitatining how to name setting, it's named: Force AA fullscreen I'ts short, but maybe it's not that clear what does it do? Alternatives could be:

• Auto switch AA to fullscreen
• Auto fullscreen on AA connect
• Force fullscreen AA when it connects
• your proposed :)

[stefan-sherwood]

Fullscreen Android Auto

[robert5974]

Maybe:

AA Fullscreen: Automatic AA Fullscreen: Auto (might sound redundant)

Maybe add another option for a delay before switch:

AA Fullscreen: Delay

Choose number Radial button for seconds or minutes

Robert Crowley

On Wed, Aug 4, 2021, 6:43 AM stefan-sherwood @.***> wrote:

Fullscreen Android Auto

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openDsh/dash/pull/87#issuecomment-892555555, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLUDVGQNJXVIXXPHGRG4M3T3EKUJANCNFSM5BPJRO3Q .

[egisz]

Initially I thought of delay, but is it really needed? It also can be inconvinient if you start AA, want to click on some UI element and suddenly it become fullscreen.

Regarding setting name, I think we can omit AA/Android auto because settings are inside AA page, so they are all related to AA :)

• Switch fullscreen on connect
• Fullscreen mode <------- this is my current favorite, simple and clear :)

[stefan-sherwood]

Simple and clear is good. I didn't realize the settings were in the AA section and I agree. How about just "Fullscreen"?

[TheBasedDoge]

Its working great for me but I noticed 2 things.

• For some reason in dark mode, not all the icons are changing to white. I noticed this in your picture as well so not sure if related.
• There is a green line on the right side of the screen in fullscreen, I don't think that was there before
• When I use the cycle pages keyboard shortcut dash goes back to windowed, maybe add a toggle to keep that persistent?

"fullscreen mode" sounds the best to me, simple and clear.

[egisz]

Its working great for me but I noticed 2 things.

• For some reason in dark mode, not all the icons are changing to white. I noticed this in your picture as well so not sure if related.

Tested on develop branch, and it is same, so this is not relevant to this update, please report it as separate isssue See screenshot below, power and exit buttons are too dark for dark theme...

• There is a green line on the right side of the screen in fullscreen, I don't think that was there before

I noticed this also, but checked on develop branch it also exist, so it is not relevant to this update. Please report it as separate Issue.

• When I use the cycle pages keyboard shortcut dash goes back to windowed, maybe add a toggle to keep that persistent?

Good point! I'll try fix this.

[robert5974]

I've been noticing the green line myself too. It's not noticeable when not Fullscreen but I could see it. I use the official Raspberry Pi 7" screen. Does anybody that has a different screen see this?

As in, is it seen in a different resolution than 800x480?

[TheBasedDoge]

I've been noticing the green line myself too. It's not noticeable when not Fullscreen but I could see it. I use the official Raspberry Pi 7" screen. Does anybody that has a different screen see this?

As in, is it seen in a different resolution than 800x480?

yes, i am using 1024x600

[egisz]

When I use the cycle pages keyboard shortcut dash goes back to windowed, maybe add a toggle to keep that persistent?

Pushed new commit to branch, it now toggles fullscreen when cycling between pages Also renamed setting label to Fullscreen mode.

[TheBasedDoge]

cool! i will try it

[rsjudka]

not ignoring this, but looks like the changes are touching more than just the AA page now so i want to look at it a bit closer

[egisz]

Yes, I did not mention, but latest update introduces fullscreen mode globally, not only in AA window. Reason why I did this is because I also wanted backup camera fullscreen. Maybe it would be also better option for some widgets or media player.

It captures double click in all screens and toggles between fullscreen/non fullscreen mode. Added animation to hide menus (user can disable this in settings). Settings moved to Settings page/Layout page. Also added notification dialog once user switches to fullscreen to inform how to switch back. It can be disabled by checking box "Do not show again".

I tested on PC, it works well, but on Rpi, this dialog sometimes does not come up. It should appear each time I toggle screen, until I check box "Do not show again", but it only shows up once after going to full screen, but after I hit cancel, it does not. I believe it opens, but not visible. I'll try to fix this, tried multiple ways, so help would be welcome. :)

[egisz]

Finally it seems working as expected, could someone else test it?

I had problems with RPI Lite environment, but finally found solution. Actually other Dash dialogs (like Power off) also does not return Keyboard focus after closing them, but it's another story. On X11 (Raspian Desktop or Ubuntu) everything works fine, so it was bit challenging to find cause :(

Another anoying thing was that dialog was not centered because it was opened before main window is shown. Here there is anoter workaround to open dialog it inside singleshot timer.

[rsjudka]

yes ill try catching up with the PRs after I finish the vehicle widget stuff!

keyboard focus is definitely an entirely different issue for another time :p

as for the "not centered" workaround... since the dialog is a lot of custom code its entirely possible I did something wrong there. As long as the workaround isn't anything major I think its okay to keep it for now and then fix it later on

[rsjudka]

oops sorry looks like there are some conflicts with my recent commit (probs related to coloring the icons and whatnot)

mind fixing them so I can test out your changes?

[egisz]

sure, try now :)

[rsjudka]

i think some other changes might have snuck in here? (looking at the canbus stuff mainly)

[rsjudka]

so i tried running it (not on a pi so that might be a factor) but...

[egisz]

Please try now, fixed duplicate icons, that was caused by bug left during merge confict file... also fixed few annoying build warnings. It looks and works fine now

[rsjudka]

if you exit dash when in fullscreen mode, it doesn't seem to launch in fullscreen mode on the next boot (even though it shows as toggled in the settings)

[rsjudka]

if you exit dash when in fullscreen mode, it doesn't seem to launch in fullscreen mode on the next boot (even though it shows as toggled in the settings)

interesting... this is only an issue when the animation duration is 0

[rsjudka]

havent seen any movement on this and then i ended up changing how fullscreen works in #138 so its not compatible now

good news is auto fullscreen should be much simpler to do now :+1: