search

openDsh / dash

Join us on Slack! https://join.slack.com/t/opendsh/shared_invite/zt-la398uly-a6eMH5ttEQhbtE6asVKx4Q
GNU General Public License v3.0
238 stars 69 forks source link

In dark mode, not all the icons are changing to white #95

Closed egisz closed 2 years ago

egisz commented 2 years ago

Description of problem:

As noted here, For some reason in dark mode, not all the icons are changing to white.

dash-dark-icons

EDIT: Updated screenshot to ephasize problem.

stefan-sherwood commented 2 years ago

Can you be more specific about what you're expecting to see?

rsjudka commented 2 years ago

this is a legit issue, none of the icons (aside from the ones in the side bar) get colored correctly (basically they are always black which works in light mode but not dark)

I've started working on a fix that doesn't require coloring the icons everytime the theme changes to prevent those crashes

stefan-sherwood commented 2 years ago

Ah, ok I see what you're talking about now

rsjudka commented 2 years ago

fixed per #106