fixes #95 dark theme icons - Githubissues

openDsh / dash

Join us on Slack! https://join.slack.com/t/opendsh/shared_invite/zt-la398uly-a6eMH5ttEQhbtE6asVKx4Q

GNU General Public License v3.0

238 stars 69 forks source link

fixes #95 dark theme icons #96

Closed egisz closed 2 years ago

egisz commented 2 years ago

Description:

fixes #95

This condition blocks from coloring some buttons: https://github.com/openDsh/dash/blob/b985a43a34a20dade264e323578a4d55a4ec7674/src/app/session.cpp#L503

But if commented out, then some unwanted UI icons show up in other buttons :( So I found other place where this property is set and changed to true: https://github.com/openDsh/dash/blob/b985a43a34a20dade264e323578a4d55a4ec7674/src/app/session.cpp#L320

Checklist:

[X] The code change is tested and works locally.

Result:

dash-icons-fixed

rsjudka commented 2 years ago

fixed by #106