openEHR / adl-antlr

Antrl4 grammars for ADL
Apache License 2.0
1 stars 4 forks source link

UID does not parse dotted syntax #13

Closed pieterbos closed 8 years ago

pieterbos commented 8 years ago

In the spec it says in the metadata section

| SYM_UID '=' ( DOTTED_NUMERIC | GUID ) // TODO: this won't match all Oids properly

In the grammar it says GUID only, so the dotted_numeric syntax does not, parse, for example openehr-TEST_PKG-WHOLE.child_with_oid.v1.0.0

archetype (adl_version=2.0.5; rm_release=1.0.2; uid=2.4.34.666.7.2)
    openehr-TEST_PKG-WHOLE.child_with_oid.v1.0.0
wolandscat commented 8 years ago

Good catch. Oids are a real nuisance. We don't want to allow them really, but this was done in response to a request from the Australian government. I think a better solution would be an 'oid=' parameter. I'll do some checking with others on this.

wolandscat commented 8 years ago

The grammar in its current version no longer matches OIDs anywhere; meta-data ids are now all GUIDs (UUIDs).

pieterbos commented 8 years ago

Sounds like a good solution. I'll remove the OID-files from archie.