Open wolandscat opened 6 months ago
Attention: Patch coverage is 90.07353%
with 27 lines
in your changes are missing coverage. Please review.
Project coverage is 70.32%. Comparing base (
c065910
) to head (9b4d721
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This set of changes is renames and some class moves, to more systematically group openEHR RM specific classes, including xml/json/odin specific adaptations in the
openehr-rm
module.The design intent is to be able to add other RMs to Archie in a more straightforward way.
Quite a few renames of classes that were openEHR RM specific to names like
OpenehrRmXXXX
whereXXXX
was the original name. This makes it easier to know at a glance whether something is specific to one RM or not.The dependency of
OpenEHRTypeNaming
(renamed toArchieTypeNameResolver
) on openEHR RM has been removed by giving it an extra constructor parameter.The class
JacksonUtil
class (renamed toOpenehrRmJacksonUtil
since it is RM-specific) has a small change to correspond with the above, i.e. injecting the OpenEhrRmInfoLookup.getInstance()singleton into
ArchieTypeNameResolver`.Some
build.gradle
dependencies adjusted. No semantic changes.Changes all compile and tests run normally.
Further code improvements are possible so DON'T MERGE this yet!