Closed VeraPrinsen closed 3 months ago
Attention: Patch coverage is 75.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 71.80%. Comparing base (
e36d98e
) to head (d98ac4f
).
Files | Patch % | Lines |
---|---|---|
...in/java/com/nedap/archie/diff/LCSOrderingDiff.java | 75.00% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Example of the bug:
flat parent archetype:
flat child archetype:
Expected differentiated archetype:
What comes out of the differentiator at the moment:
This gives errors when flattening the archetype, and puts the specialised id2.1 element last instead of at the place of the original id2 element.
Problem was in the 'handleDirectlyAfterSameParentNode' method where the parent id code was found, but because the for loop ended, the method still returned 'false', even though there was a parent node that this specialised element could go right after.