search

openEHR / specifications-ITS-REST

openEHR REST API Specifications
https://specifications.openehr.org/releases/ITS-REST/latest
Apache License 2.0
18 stars 15 forks source link

Content-Type header in REST API calls should not be mandatory for empty content #69

Closed serefarikan closed 5 years ago

serefarikan commented 6 years ago

At various locations, the rest specification states that create calls with representation set to minimal should return only headers, and one of those headers is Content-Type. this is a grey zone: the relevant RFC (https://tools.ietf.org/html/rfc7231#section-3.1.1.5) says that a sender that sends a payload body SHOULD set the content type but it does not say that in case of no content this header should be set Moreover, the technology stack we're using is opinionated and does not let setting the content-type header when the content is empty. Unless there is an argument against it, could we please consider not making content-type header mandatory when there is no content? I realise the limitation of a tech stack is not grounds for requests for change, but in this case what the spec is asking is not making a lot of sense to me

So please consider that as the source of my request here is an example: https://www.openehr.org/releases/ITS/latest/docs/ehr.html#composition-composition-post

jakesmolka commented 5 years ago

In addition to what was changed in fd36cc3, removal of Content-Type header in 204 responses (e.g. https://specifications.openehr.org/releases/ITS-REST/Release-1.0.0/ehr.html#composition-composition-get) would make sense, too.

Should I create a new issue or can you reopen this one?

sebastian-iancu commented 5 years ago

Ah, good catch, thanks! A new issue would be more appropriate.