openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

files tag_electricity and tag_fuel_types #179

Open sandrinecharousset opened 2 years ago

sandrinecharousset commented 2 years ago

Those 2 files are 90% identical : is there a reason why the 2 exist? SHouldn't we merge them? It may create unconcistencies if one is modified and not the other.... @danielhuppmann @tburandt @erikfilias any idea?

sandrinecharousset commented 2 years ago

paths of the 2 files: https://github.com/openENTRANCE/openentrance/blob/3143bfb24f91f868ef3a8134a0620aa0556b68ab/definitions/variable/tag_electricity_input_types.yaml https://github.com/openENTRANCE/openentrance/blob/3143bfb24f91f868ef3a8134a0620aa0556b68ab/definitions/variable/tag_fuel_types.yaml

erikfilias commented 2 years ago

paths of the 2 files: https://github.com/openENTRANCE/openentrance/blob/3143bfb24f91f868ef3a8134a0620aa0556b68ab/definitions/variable/tag_electricity_input_types.yaml https://github.com/openENTRANCE/openentrance/blob/3143bfb24f91f868ef3a8134a0620aa0556b68ab/definitions/variable/tag_fuel_types.yaml

From my understanding, we created the tag_fuel_types at the beginning for naming the sources of the electricity generation. However, now, it is the purpose of tag_electricity. I'm not sure the purpose of the fuel types since it is not considered for electricity generation, but maybe it is useful for other energy carriers.

sandrinecharousset commented 2 years ago

@erikfilias , I finally digged the directory and found an old discussion raised by @HauHe about this which explains why there are 2 different files What I understand is that fuel_types is only for fuels eg you will find gas|biomethane but not gas|ocgt, or solar and not solar|pv while electricity_input is for creating all names of different power plants, where you may have much more different cases such as gas|biomethane|ocgt , gas|ccgt...... So in the end I believe that unless we find a better way (which may be tricky), we stick to that separation..... Sorry for raising an irrelevant issue