search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Update IMAGE mapping try 2 #228

Closed MarkMDekker closed 2 years ago

MarkMDekker commented 2 years ago

@danielhuppmann do you see what I am doing wrong here? I tried to update both the native regions (other pull request) and the mapping between regions; include all IMAGE regions instead of only the European ones, and in particular the "World" region. Perhaps it needs some time to process the native regions, before changing the mapping?

danielhuppmann commented 2 years ago

The validation checks that the region-mapping is consistent with the defined regions (in definitions/region). The validation is failing because #226 is not merged yet. Preferably (i.e., next time), you should add the region-definition and the mapping as one PR.

MarkMDekker commented 2 years ago

Clear. Will combine the changes in one PR next time. Thanks for your quick response!