search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Change name to area_name #234

Closed phackstock closed 2 years ago

phackstock commented 2 years ago

Changing the attribute name in the region codelist files nuts1.yaml, nuts2.yaml and nuts3.yaml to area_name. An attribute named name causes issues with the latest nomenclature release. Running the tests, it seems we have another issue that will need to be fixed on the nomenclature side concerning multiple units.

phackstock commented 2 years ago

Opened iamconsortium/nomenclature#197 to address the currently failing tests. After this is merged we can check again if the tests run.

phackstock commented 2 years ago

Looks like there's a few gremlins left. I'll investigate further.

phackstock commented 2 years ago

Maybe a good idea for the future for any nomenclature unit/integration test would be to run against openENTRANCE.

phackstock commented 2 years ago

Looks like there's a few last issues to fix. I'm taking a look.

phackstock commented 2 years ago

Looks like it's all good now. @danielhuppmann, I'll go ahead with the merge to restore the service.