search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Add LIMES v.2.38 native regions and mappings #240

Closed joanna-sitarz closed 1 year ago

joanna-sitarz commented 1 year ago

New file defining native regions and mappings in LIMES v.2.38 (for ECEMF project)

danielhuppmann commented 1 year ago

Thanks @joanna-sitarz for this PR - and my apologies, I sent you down the wrong rabbit hole...

Per the suggestion in the ECEMF-internal forum by @HauHe here, we simplified the region-mapping for models that have a country-level resolution. See also #233.

For your use case (if you submit with ISO3 codes), you can copy over the file https://github.com/iiasa/eu-climate-advisory-board-workflow/blob/main/mappings/eu-countries-iso3.yaml to the mappings folder - there is no need to define native-regions of the format LIMES 2.38|<code>.

I suggest to close this PR and start a new PR.

joanna-sitarz commented 1 year ago

Hi @danielhuppmann many thanks for your help! I will close this PR and open a new one. Just to be sure: LIMES has a country resolution and I can submit with ISO3 but there are still some minor differences compared to the file https://github.com/iiasa/eu-climate-advisory-board-workflow/blob/main/mappings/eu-countries-iso3.yaml (i.e., we don't have Malta, Cyprus and Iceland). Can I still introduce as "common region" e.g. EU-27 but just leave Malta and Cyprus out (as it's our approximation of EU-27)?

danielhuppmann commented 1 year ago

Can I still introduce as "common region" e.g. EU-27 but just leave Malta and Cyprus out (as it's our approximation of EU-27)?

Please keep these extra regions that should be in EU-27 but are not reported by this model - this will simplify re-using this generic mapping for other models with a country-level resolution. The region-processing of the nomenclature package will simply ignore if data for a listed region is not reported.

joanna-sitarz commented 1 year ago

Thank you! I am closing this PR and will open a new one.

danielhuppmann commented 1 year ago

closed in favor of #241