search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Add WITCH 5.0 with one Europe region #258

Closed JohannesEmm closed 1 year ago

JohannesEmm commented 1 year ago

Given not yet clear 2030 effort sharing for Ff55 unique EU market as alternative for WP1 submissions.

JohannesEmm commented 1 year ago

Dear Daniel, Philipp: I have to add an alternative WITCH region definition, which I replicated form the existing one, as WP1 requires some uploads quite timely @danielhuppmann @phackstock I tried to check the error message, which actually seems to be OK but not sure why it fails. IN case could you kindly quickly check?

"WITCH 5.0 Region(s) ['WITCH 5.0|BRAZIL', 'WITCH 5.0|CANADA', 'WITCH 5.0|CHINA', 'WITCH 5.0|EUROPE', 'WITCH 5.0|INDIA', 'WITCH 5.0|INDONESIA', 'WITCH 5.0|JPNKOR', 'WITCH 5.0|LACA', 'WITCH 5.0|MENA', 'WITCH 5.0|MEXICO', 'WITCH 5.0|OCEANIA', 'WITCH 5.0|SASIA', 'WITCH 5.0|SEASIA', 'WITCH 5.0|SOUTHAFRICA', 'WITCH 5.0|SSA', 'WITCH 5.0|TE', 'WITCH 5.0|USA'] in mappings/witch_5.0.yaml not defined in the DataStructureDefinition (type=value_error.region_not_defined; region=['WITCH 5.0|BRAZIL', 'WITCH 5.0|CANADA', 'WITCH 5.0|CHINA', 'WITCH 5.0|EUROPE', 'WITCH 5.0|INDIA', 'WITCH 5.0|INDONESIA', 'WITCH 5.0|JPNKOR', 'WITCH 5.0|LACA', 'WITCH 5.0|MENA', 'WITCH 5.0|MEXICO', 'WITCH 5.0|OCEANIA', 'WITCH 5.0|SASIA', 'WITCH 5.0|SEASIA', 'WITCH 5.0|SOUTHAFRICA', 'WITCH 5.0|SSA', 'WITCH 5.0|TE', 'WITCH 5.0|USA']; file=mappings/witch_5.0.yaml)"

PS: When comparing to the NAVIGATE workflow, I noted a number of differences, notably casing of region definitions and names, casing and "_/+" replacement of the yaml file names etc. I used the one found in openentrance, or which convention to be used in the future? I here just used the ones from the previous one so should be OK for openentrance.

Thanks a lot!

danielhuppmann commented 1 year ago

Thanks @JohannesEmm, tests now pass - but are you sure that you want to have all-caps names shown in the Scenario Explorer? In terms of readability, the inverse solution would be better, I think...

JohannesEmm commented 1 year ago

Just checked all the other models which also seem to have upper case model names (which are indeed a bit cryptic). While navigate_workflow for instance have all Title Case and more explanatory names, so kept it for consistency (also between both model versions here in ECEMF/openentrance. But can of course change it, if you prefer.

danielhuppmann commented 1 year ago

I'd suggest to move towards readibility wherever possible - the linkage to the region-name as used internally in your model can always be traced back via the mappings-file.

JohannesEmm commented 1 year ago

OK, now should be OK.

danielhuppmann commented 1 year ago

Added permissions for WITCH modelers to submit scenarios to the ECEMF-internal Scenario Explorer.