openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Create seasons.yaml #278

Closed sandrinecharousset closed 1 year ago

sandrinecharousset commented 1 year ago

Description of seasons : this is used to separate a value (eg yearly energy) per season (eg. energy used in winter....) The dates of seasons changing was chosen arbitrarily to the 21st as this is minimising the diffeence of length between seasons, which if sticking to the official calendar is usually bigger

sandrinecharousset commented 1 year ago

Looks good to me, thanks! Has this been discussed within the relevant case studies? In other words, does this still need to be discussed or can I go ahead and merge the PR)?

Thanks @danielhuppmann ; This is something that we need for uploading results of CS1 and CS4, which I will be doing very soon. It has not been discussed under the umbrella of the nomenclature, but a significant part of our results are presented 'per season' ; Nevertheless it seems only plan4EU results (for CS1, CS4 and CS5) need this so I may be the only person in the discussion..... Now I am working on the less easy part which is a representative week per season (which in terms of computation is the average hourly timeseries over all weeks included in 1 season.....). All ideas welcome :-) To answer your question I think yes you can merge this one, unless you prefer to wait for the following and merge both together

sandrinecharousset commented 1 year ago

Just added a new yaml file for representative time slices (here representative or average weeks per seasons)..... Would be gratefull to get some comments / advices about it as I am 99% sure there are better ways to write this..... @danielhuppmann @erikfilias

I included a tag for the seasons ; I already have the list of seasons in the seasons.yaml file but apparenty it wasn't enough as it did not pass the tests, so I added a file for the tags. Still didn't work so I changed the first lettre from capital to not capital in the tag list as maybe having a tag list identical to a definition list is not good..... and now it works......

danielhuppmann commented 1 year ago

I cherry-picked the suggested definitions for the seasons so that at least data at this resolution can be submitted (see #279).

I still do not understand what hhh is supposed to mean and how this is supposed to work. Can you please send me a small data file in the IAMC/openENTRANCE format that has this resolution?

sandrinecharousset commented 1 year ago

@danielhuppmann , I tried to change the seasons.yaml to avoid double use of Winter , Autumn...... As seasons are described as a 'tag', I wanted to describe the seasons.yaml as {Season Input} but it doesn't pass the validation..... Is it forbidden to use a {} as first part of a name?

danielhuppmann commented 1 year ago

Closing in favor of #283