search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Add discharged/Injected Energy for residential load shifting assets #280

Closed sandrinecharousset closed 1 year ago

sandrinecharousset commented 1 year ago

load shifting assets are 'equivalent' to short term storages but the variables were not defined These variables are required for uploading openentrance CS1 results

sandrinecharousset commented 1 year ago

@erikfilias I reasked you ot revew as I added 2 more changes to the same file and so did not want to create a new PR as I would have gotten conflicts (and I never lnow how to solve them).......

sandrinecharousset commented 1 year ago

Is there a strong reason to allow multiple units for so many variables? In my experience this just creates a headache for users when they want to analyze results and have to bother getting all data for a particular variable into the same unit...

I would say yes : we are allowing different communities to use them and I have experienced headaches analysing data which were in a unit I had never heard of (Ej/yr)…. In the power system community energies are expressed in GWh ; MWh and GWh are very easy to play with so will not give headaches …… We could have kept only one of the 2, anyway this is not a change from the current pr and was accepted months ago….