search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Added Maximum Storage for Hydro|Reservoir and Hydro|Pumped Storage #286

Closed sandrinecharousset closed 1 year ago

sandrinecharousset commented 1 year ago

When we added the tags for energy storage system, the variable names for storage were redefined with an additionnal section which is |Energy Storage System| This creates an inconsistency in variable names for hydro power: we do have Secondary Energy|Hydro|Reservoir and Capacity|Hydro|Reservoir (which are needed to remain unchainged) for instance but when we need Maximum Storage|Hydro|Reservoir does not exist, instead it is - Maximum Storage|Energy Storage System|Hydro|Pumped Storage, which is not consistent, too complicated and useless (as it is obvious that Reservoir and Pumped Storage are storage); I had thought that it could be possible to allow both names but it doesn't work as we have defined Capacity|{electricity input} and capacity|{electricity storage system} which means that a variable would be duplicated. My suggestion is then to remove Reservoir and Pumped Storage from the list of {Energy storage systems} ; Before doing that I added the variable which I needed which are Maximum Storage|Hydro|Reservoir and Maximum Storage|Hydro|Pumped Storage

danielhuppmann commented 1 year ago

You can never achieve perfect consistency across the variable tree, so I suggest to keep the current structure - otherwise, we will have an inconsistency between difference storage types like

If you really want to harmonize, I'd rather suggest to remove the "Energy Storage System" level.

sandrinecharousset commented 1 year ago

You can never achieve perfect consistency across the variable tree, so I suggest to keep the current structure - otherwise, we will have an inconsistency between difference storage types like

  • Maximum Storage|Electricity|Hydro|Reservoir
  • Maximum Storage|Electricity|Energy Storage System|Lithium-Ion

If you really want to harmonize, I'd rather suggest to remove the "Energy Storage System" level.

Yes I agree, will propose a PR achieving this and see if @erikfilias can cope with it. The Energy storage system level does to my opinion add nothing apart from complexification

erikfilias commented 1 year ago

You can never achieve perfect consistency across the variable tree, so I suggest to keep the current structure - otherwise, we will have an inconsistency between difference storage types like

  • Maximum Storage|Electricity|Hydro|Reservoir
  • Maximum Storage|Electricity|Energy Storage System|Lithium-Ion

If you really want to harmonize, I'd rather suggest to remove the "Energy Storage System" level.

Yes I agree, will propose a PR achieving this and see if @erikfilias can cope with it. The Energy storage system level does to my opinion add nothing apart from complexification

Yeah, I also agree about removing it.

sandrinecharousset commented 1 year ago

Included in #291