search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Added max. heat storage #288

Closed amosschle closed 1 year ago

amosschle commented 1 year ago

CS7 results include maximum heat storage (MWh). If I understand correctly, only electricity storage is supported by the nomenclature, currently.

sandrinecharousset commented 1 year ago

@amosschle heat storage could be included in the diverse storage systems that were defined in l definitions/variable/tag_electricity_storage_types.yaml ; As you are not referring to an electricity storage I would suggest to rename tag_electricity_storage_types.yaml as tag_storage_types.yaml , and add a new section - Heat Storage Type: in which you could define - Energy Storage System|Heat ; then in technology.yaml you could define Max Storage|{Heat Storage Type} which would create the variable Max Storage|Energy Storage System|Heat and give also the possibility to further create new variables Max Storage|Energy Storage System|Heat|system1 ..... (and naturally Max Storage|Energy Storage System|Heat=sum of all Max Storage|Energy Storage System|Heat|systemi @erikfilias @danielhuppmann any idea?

erikfilias commented 1 year ago

@amosschle heat storage could be included in the diverse storage systems that were defined in l definitions/variable/tag_electricity_storage_types.yaml ; As you are not referring to an electricity storage I would suggest to rename tag_electricity_storage_types.yaml as tag_storage_types.yaml , and add a new section - Heat Storage Type: in which you could define - Energy Storage System|Heat ; then in technology.yaml you could define Max Storage|{Heat Storage Type} which would create the variable Max Storage|Energy Storage System|Heat and give also the possibility to further create new variables Max Storage|Energy Storage System|Heat|system1 ..... (and naturally Max Storage|Energy Storage System|Heat=sum of all Max Storage|Energy Storage System|Heat|systemi @erikfilias @danielhuppmann any idea?

I also agree with @sandrinecharousset about renaming the tag related to storage type and including these variables there.

amosschle commented 1 year ago

Thanks for the quick review, @sandrinecharousset and @erikfilias. I've made the requested changes.

danielhuppmann commented 1 year ago

There can be only one tag-list per file, please revert the name change of the electricity-storage-type-file and put the heat-storage-types in a separate file.

sandrinecharousset commented 1 year ago

included in #291

sandrinecharousset commented 1 year ago

included in #291