search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Add Maximum Storage|{Storage Type} #301

Closed amos-schledorn closed 1 year ago

amos-schledorn commented 1 year ago

Following the suggestion by @sandrinecharousset This PR allows for Maximum Storage|Heat, which is an output of CS 7.

danielhuppmann commented 1 year ago

No, this PR does not add a variable "Maximum Storage|Heat". Please explain what you intend to do (and why).

sandrinecharousset commented 1 year ago

No, this PR does not add a variable "Maximum Storage|Heat". Please explain what you intend to do (and why).

@danielhuppmann , it adds Maximum Storage|{Storage Type}: , and as Heat is included in {Storage Type}, it adds Maximum Storage|Heat (and other variables)

It is a bit difficult to add this variable (which is needed and which needs to be different as the already existing Maximum Storage|Electricity|Heat without changing everything (which we cant as lots of data are already made public)

Maximum Storage|€lectricity|{Storage Type} ismeant or representing electrcity storage (which also include 'virtual electricity storage, eg Maximum Storage|Electricity|Hydro|Reservoir ; Here what is really stored is water (m3) but what is seen by the models is electricity (GWh) ; We have the same thing for heat => Maximum Storage|Electricity|Heat represents an amount of (virtually) stored electricity , which is stored as heat , while Maximum Storage|Heat represents a real storage of heat. The same amount of heat (in a physical unit for heat) would not lead to the same amount of energy (in EJ or GWh) due to efficiency

We discussed with Amos and I proposed to include this Maximum Storage|{storage type} as it was simple, would not break everyhting , and was not completely studîd (but it should not appear in power-plants.yaml, maybe in technologies.yaml would be more relevant), and also I thought it could start a discussion towards maybe a better idea :-)

Another way ould be

sandrinecharousset commented 1 year ago

Dont' know why my comment was cut..... Another way would be to add Maximum Storage|Heat in technologies.yaml

danielhuppmann commented 1 year ago

Sorry, I was too short in my reply - yes, this PR would technically add the variable "Maximum Storage|Heat", but it would also add "Maximum Storage|Electric Vehicle" and a set of other variables that do not make sense.

The reason why I don't think this PR is a good idea is that the storage-type list is intended for technologies that can store electricity. The variables should have a structure like "Maximum Storage|\<Energy Carrier>|\<Storage Type>".

So please simply add a variable "Maximum Storage|Heat" without using the tag-list. If you want to disambiguate between different storage options, please rename the existing "Storage Type" list to "Electricity Storage Type" and add a new "Heat Storage Type" list.

danielhuppmann commented 1 year ago

@amosschle, can you please refactor the PR (or close this and start a new one) to simply add a variable "Maximum Storage|Head" and explain in a note how that variable is to be interpreted and used?

amos-schledorn commented 1 year ago

@amosschle, can you please refactor the PR (or close this and start a new one) to simply add a variable "Maximum Storage|Head" and explain in a note how that variable is to be interpreted and used?

@danielhuppmann, sorry for this coming so late. I hope the latest commit works.