search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Add definitions and mappings for REMIND 3.2 #326

Closed danielhuppmann closed 4 months ago

phackstock commented 4 months ago

Ah that's different to iamconsortium/nomenclature#319 though. This one's failing because I cleaned up the CLI and adjusted it to the standard of giving multiple input values. From:

nomenclature validate-project . --dimensions "['region', 'scenario', 'variable']"

you'll now have to do:

nomenclature validate-project . --dimensions region --dimensions scenario --dimensions variable

Reason for the change was that the first solution was a custom one from us, the current one adheres to the standards of CLI programs. I could think about offering a shorthand -d to make the command shorter.

robertpietzcker commented 4 months ago

I am sorry, I didn't think before when replying to the email... is this supposed to be a different REMIND version than the one Renato used before? I think not, or do you disagree, @Renato-Rodrigues ?

danielhuppmann commented 4 months ago

is this supposed to be a different REMIND version than the one Renato used before?

No scenarios were submitted to the ECEMF-internal Scenario Explorer from REMIND 3.2 yet. This PR is just a fix such that native-region-names are "REMIND 3.2|..." instead of "REMIND 3.0|...". The mapping assumes the 21-region-version of REMIND, simplifying the mappings.

Please review that my allocation of the non-EU European countries to the iso3_codes-attribute are correct - I copied them from the REMIND 3.1 definitions at https://github.com/IAMconsortium/common-definitions/blob/main/definitions/region/native_regions/REMIND_3.1.yml.

I also noticed that REMIND submits already-aggregated for "EU27" in some project - are you also planning to do this for REMIND 3.2 in the ecemf-internal instance?

Renato-Rodrigues commented 4 months ago

No scenarios were submitted to the ECEMF-internal Scenario Explorer from REMIND 3.2 yet.

There was no change in the regions definitions from REMIND 3.0 to REMIND 3.1 or REMIND 3.2. Therefore, a few 3.2 results were already uploaded using the previous mapping. So my question is why did you not copied directly the below mapping? https://github.com/IAMconsortium/common-definitions/blob/main/mappings/REMIND_3.1.yml

The mapping assumes the 21-region-version of REMIND, simplifying the mappings.

REMIND results can be uploaded in both 12-regions and 21-regions configurations, so I would not remove the support to the 12 regions (EUR and NEU).

Please review that my allocation of the non-EU European countries to the iso3_codes-attribute are correct

They should be correct, but I will double check them soon.

I also noticed that REMIND submits already-aggregated for "EU27" in some project - are you also planning to do this for REMIND 3.2 in the ecemf-internal instance?

Yes, we handle ourselves our EU27 regions aggregations and upload them directly.

One last point, any special reason why you removed the support for the R10 automatic aggregation of AR6 regions from the 3.1 common-definitions mapping?

danielhuppmann commented 4 months ago

Note that ECEMF does not use R9 and R10 region definitions (yet?), that's why I started from https://github.com/openENTRANCE/openentrance/blob/main/mappings/remind_3.0.yaml, not the mapping in common-definitions. In turn, the common-definitions repository does not have the INNOPATHS mappings...

Also, no results using REMIND 3.2 were yet submitted to the ecemf-internal database (Simon Moreno tried yesterday but failed, this PR is fixing the registration so that he can proceed).

danielhuppmann commented 4 months ago

Permissions added for the REMIND team to submit scenarios for REMIND 3.2 to the ECEMF-internal Scenario Explorer