openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Update tag_storage_types.yaml #338

Closed sandrinecharousset closed 2 weeks ago

sandrinecharousset commented 1 month ago

The comment says 'does not include hydro' but Pumped Storage was still included.... which would create variables such as eg Capacity|Electricity|Pumped Storage while the use of Electricity Input creates Capacity|Electricity|Hydro|Pumped storage I propose to remove pumped storage from storage_types

erikfilias commented 1 month ago

@sandrinecharousset, I also agree. Because some variables related to storage_type are also defined for pumped-storage hydro. For example: Charging Efficiency|Electricity|Hydro|Pumped Storage: in power-plant.yaml.

sandrinecharousset commented 2 weeks ago

@phackstock could you have a look and merge if ok?