search

openENTRANCE / openentrance

Definitions of common terms (variables, regions, etc.) for the openENTRANCE project
http://openentrance.eu
Apache License 2.0
30 stars 49 forks source link

Inconsistency in the subcountry definitions (of France) #72

Closed philipphaertel closed 4 years ago

philipphaertel commented 4 years ago

There seems to be some inconsistency in the subcountries.yaml definitions of the French subgrid regions.

Specfically, the following nuts regions cannot be found in the nuts3.yaml (or recent shape layer information from https://gisco-services.ec.europa.eu/distribution/v2/nuts/): Cannot find nuts id FR613 Cannot find nuts id FR627 Cannot find nuts id FR824 Cannot find nuts id FR515 Cannot find nuts id FR246 Cannot find nuts id FR715 Cannot find nuts id FR521 Cannot find nuts id FR252 Cannot find nuts id FR223

If it is not possible to match the definition with current NUTS versions used in the nuts3.yaml definitions (2016/21), it might help to further specify the NUTS version the subregion definition is referring to.

Thanks

danielhuppmann commented 4 years ago

Indeed, thank you @philipphaertel for highlighting this error...

This was added by in PR #20. @sandrinecharousset, could you please review the mapping of ehighways2050 regions to NUTS-codes? For reference, the xlsx source file used to generate the NUTS-region classification is available in a separate branch danielhuppmann:attachment/nuts-regions (see the region/data folder).

sandrinecharousset commented 4 years ago

@philipphaertel thank you for noticing this The error came from a bug in the macro converting nuts2013 to nuts 2021 (as ehighway uses the nuts2013 nomenclature and we are using nuts2021....) I have corrected all subregions for france

philipphaertel commented 4 years ago

Thanks for fixing the definitions, @sandrinecharousset New definitions work on my end.