search

openEOPlatform / documentation

Documentation for openEO Platform
https://docs.openeo.cloud
Apache License 2.0
1 stars 5 forks source link

Update collections.md #30

Closed dthiex closed 2 years ago

jdries commented 2 years ago

@m-mohr @dthiex @ValentinaHutter @christophreimer @bschumac I took the liberty of extending Daniel's pull request to come to a first draft of a harmonized collection spec. I mostly limited myself to the things that I think are agreed upon already, so that we can quickly approve and have at least something on the web page.

m-mohr commented 2 years ago

Looks good to me, but I support Daniel's change requests.

jdries commented 2 years ago

@jdries Would you be okay with the suggestions in my comment?

Yes! I may need to look a bit further

dthiex commented 2 years ago

I took the liberty of extending Daniel's pull request to come to a first draft of a harmonized collection spec. I mostly limited myself to the things that I think are agreed upon already, so that we can quickly approve and have at least something on the web page.

Thanks a lot for adding some substance to this. Let's wait for someone from EODC to look at this and then merge it to have an initial version out and improve on it when necessary.

jdries commented 2 years ago

@dthiex agree with your proposal for angles as well. Will you extend it with the other angles? (I added some placeholders.)

dthiex commented 2 years ago

Will you extend it with the other angles? (I added some placeholders.)

@jdries Not sure what exactly you mean here. How I see it, we use both the exact angles for sunAzimuth and sunZenith so I think there is no generalisation needed here so I'd say we can remove those from here.

bschumac commented 2 years ago

This is fine for EODC, you can go ahead. Please let us know if you need any more information.

jdries commented 2 years ago

@jdries Not sure what exactly you mean here. How I see it, we use both the exact angles for sunAzimuth and sunZenith so I think there is no generalisation needed here so I'd say we can remove those from here.

@dthiex indeed, so we only need to add the harmonized names, and explain that these are in fact the exact angles. I think we can merge after that.

dthiex commented 2 years ago

@jdries @m-mohr You are too fast for me... Thanks 🙇